-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Eleventy icon #1698
Add Eleventy icon #1698
Conversation
Sorry, I have to fix the "viewBox" property... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual vectorization looks very nice @svillegascreative, good job 👌 Because the vectorization was manual I will leave it to a second maintainer to review this as well and merge it in 🙂
The vectorization looks good! I do have to ask though: is there a reason for the background to be a rectangle, as opposed to e.g. a square, or simply having the "11ty" letters without a background? I see that their logo PNG is of the same format as this PR, but I think that's because the background isn't visible when it's used. Opinions @ericcornelissen @svillegascreative? |
When you look at the docs and the GitHub organisation you see that the logo is used as a rectangle. That said, there are also cases where it is ambiguous (e.g. their twitter) or a square (e.g. the favicon or this tweet). For that reason, I'm fine either way but I think the rectangle is preferred by them in general. We could ping the maintainer of Eleventy with an @-mention? |
@ericcornelissen I clearly didn't check deep enough. My bad! With those examples I definitely agree that the rectangle is perfectly fine. 👍 Thanks for your work on this @svillegascreative! Your contribution is much appreciated. |
# New icons - Terraform (#1674) - Google Scholar (#1677) - TensorFlow (#1683) - Skillshare (#1686) - Eleventy (#1698) - GreenSock (#1691) - PyTorch (#1689) - Qgis (#1697) - Xiaomi (#1687) - MuseScore (#1685) - Gentoo (#1688) - McAfee (#1700) # Updated icons - Laravel (#1692) # Miscellaneous - Now available for PHP through packagist (#1611) - SVG files may no have a final newline (#1682)
Yay! Thank you! |
Issue:
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
My first PR! Please let me know if I missed anything, and apologies for any mistakes!