Add Skillshare icon #1686
Merged
Add Skillshare icon #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looking very good @foo-dogsquared 👌 I have just one small suggestion with regards to the metadata.
ericcornelissen
approved these changes
Oct 4, 2019
|
Thanks a lot for your work on this @foo-dogsquared 🎉 It is very much appreciated! |
birjj
added a commit
that referenced
this pull request
Oct 6, 2019
# New icons - Terraform (#1674) - Google Scholar (#1677) - TensorFlow (#1683) - Skillshare (#1686) - Eleventy (#1698) - GreenSock (#1691) - PyTorch (#1689) - Qgis (#1697) - Xiaomi (#1687) - MuseScore (#1685) - Gentoo (#1688) - McAfee (#1700) # Updated icons - Laravel (#1692) # Miscellaneous - Now available for PHP through packagist (#1611) - SVG files may no have a final newline (#1682)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1411
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
The logo I've picked is the primary logo as seen from the branding and logo page.
Here is a direct link of the image.
I picked the brand color (named Skillshare Blue) from their color guidelines.
It is also the same color at the header, anyways.
I have manually vectorized the logo with Inkscape since I don't see an SVG file of the logo.
The text logo does have an SVG but I don't think it's suitable to be submitted when they have an icon.
I tried my best to polish the tiny details without screwing it up. ;p