Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Qgis icon (#1694) #1697

Merged
merged 6 commits into from
Oct 5, 2019
Merged

Added Qgis icon (#1694) #1697

merged 6 commits into from
Oct 5, 2019

Conversation

tilak999
Copy link
Contributor

@tilak999 tilak999 commented Oct 4, 2019

Issue:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Why did you pick the hex value?
    • Hex value provided in design docs.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 4, 2019
ericcornelissen
ericcornelissen suggested changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job on this Pull Request @tilak999! It requires two minor changes before we can merge it, but all-in-all this is a very good start 👍

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/qgis.svg Outdated Show resolved Hide resolved
@ericcornelissen ericcornelissen merged commit ac531b5 into simple-icons:develop Oct 5, 2019
@ericcornelissen ericcornelissen mentioned this pull request Oct 6, 2019
Merged
birjj added a commit that referenced this pull request Oct 6, 2019
@birjj
Publish 1.17.0
1cf5898 
# New icons

- Terraform (#1674)
- Google Scholar (#1677)
- TensorFlow (#1683)
- Skillshare (#1686)
- Eleventy (#1698)
- GreenSock (#1691)
- PyTorch (#1689)
- Qgis (#1697)
- Xiaomi (#1687)
- MuseScore (#1685)
- Gentoo (#1688)
- McAfee (#1700)

# Updated icons
- Laravel (#1692)

# Miscellaneous

- Now available for PHP through packagist (#1611)
- SVG files may no have a final newline (#1682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tilak999 @ericcornelissen