[Add] Xiaomi icon #1687
Merged
[Add] Xiaomi icon #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcornelissen
suggested changes
Oct 4, 2019
There was a problem hiding this comment.
The PR looks really good, it requires just two small changes before we can merge this. First, as per the Contributing Guidelines, the SVG needs a role="image" attribute (which is why the Travis CI build is failing) and second is that we want the SVG file to be a single line. Once you changed that this PR can be merged! 👍
Add `role` attribute and minimise to one line.
ericcornelissen
approved these changes
Oct 5, 2019
|
Thanks a lot for your work on this @mudlabs 🎉 It is very much appreciated! |
birjj
added a commit
that referenced
this pull request
Oct 6, 2019
# New icons - Terraform (#1674) - Google Scholar (#1677) - TensorFlow (#1683) - Skillshare (#1686) - Eleventy (#1698) - GreenSock (#1691) - PyTorch (#1689) - Qgis (#1697) - Xiaomi (#1687) - MuseScore (#1685) - Gentoo (#1688) - McAfee (#1700) # Updated icons - Laravel (#1692) # Miscellaneous - Now available for PHP through packagist (#1611) - SVG files may no have a final newline (#1682)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
No related issue.
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description