Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gentoo icon #1688

Merged
merged 3 commits into from
Oct 5, 2019
Merged

Conversation

foo-dogsquared
Copy link
Contributor

@foo-dogsquared foo-dogsquared commented Oct 3, 2019

Issue: #1592

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

They have an official monochrome version so I picked that as the logo for this entry.

The brand color (named Gentoo purple) is chosen from the official color palette.

I manually "vectorized" the logo with Inkscape.
Making a vector for this particular logo has gone through a weird process.
With my amateur experience, I can't properly combine the individual nodes of the SVG.
So I converted the SVG into a high-resolution PNG then vectorized it again to make a single <path> node. :|

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Oct 4, 2019
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually "vectorized" the logo with Inkscape. Making a vector for this particular logo has gone through a weird process. With my amateur experience, I can't properly combine the individual nodes of the SVG. So I converted the SVG into a high-resolution PNG then vectorized it again to make a single node. :|

What do you mean by "manually vectorized the logo". The logo is already available in vector format (SVG) and all that is required for this logo is to resize it into a 24x24 viewbox. Care to elaborate?

@foo-dogsquared
Copy link
Contributor Author

Basically, I tried to combine the logo into one path but there is always an overlap with the combinations I've had (thus, there's always manual editing required).

So I tried to convert the vector into a high-resolution PNG then create a vector out of it.

@foo-dogsquared
Copy link
Contributor Author

I'm going to update the SVG file.
I just figured it out how to combine the nodes (without the overlap) now in Inkscape. 😅

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just figured it out how to combine the nodes (without the overlap) now in Inkscape. 😅

That's great to hear, using an official vector format is always better, you can see the small difference it makes.

@ericcornelissen ericcornelissen merged commit 12dfd1e into simple-icons:develop Oct 5, 2019
@ericcornelissen
Copy link
Contributor

Thanks for you work on this one @foo-dogsquared your contributions over the past week mean a lot to us as maintainers of this project 😄

@foo-dogsquared
Copy link
Contributor Author

I'm just getting into using Inkscape so I thought I could help out with this project as a starting point.
I also appreciate your patience while I'm sorting things out. :)
It means a lot for a new contributor.

@foo-dogsquared foo-dogsquared deleted the gentoo branch October 5, 2019 16:25
birjj added a commit that referenced this pull request Oct 6, 2019
# New icons

- Terraform (#1674)
- Google Scholar (#1677)
- TensorFlow (#1683)
- Skillshare (#1686)
- Eleventy (#1698)
- GreenSock (#1691)
- PyTorch (#1689)
- Qgis (#1697)
- Xiaomi (#1687)
- MuseScore (#1685)
- Gentoo (#1688)
- McAfee (#1700)

# Updated icons
- Laravel (#1692)

# Miscellaneous

- Now available for PHP through packagist (#1611)
- SVG files may no have a final newline (#1682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants