This repository was archived by the owner on Nov 19, 2021. It is now read-only.
FIX: the "chat" event should return the full "stanza.attrs.from" string #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le-yak
changed the title
|
Brain fart, sorry for the trouble. The change was actually made during bac1433, and the code is compliant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "from" parameter returned by the "chat" event contains only the room name, not the actual sender. This is not what the README says, and is not consistent with other events, e.g. groupchat.
This changed during commit 4554713, and looks like a debug code left by mistake.
Possibly answers #82.