Fix parent directory patterns with gitignore option

Fixes #133

Author: sindresorhus

ignore.js

@@ -82,7 +82,9 @@ const toRelativePath = (fileOrDirectory, cwd) => {
 		// isPathInside returns false for equal paths, so check this case first
 		const relativePath = path.relative(cwd, fileOrDirectory);
 		if (relativePath && !isPathInside(fileOrDirectory, cwd)) {
-			throw new Error(`Path ${fileOrDirectory} is not in cwd ${cwd}`);
+			// Path is outside cwd - it cannot be ignored by patterns in cwd
+			// Return undefined to indicate this path is outside scope
+			return undefined;
 		}
 
 		return relativePath;

tests/globby.js

@@ -638,6 +638,58 @@ test('nested gitignore with negation applies recursively to globby results (issu
 	t.false(result.includes('y/z/a1.txt'));
 });
 
+test.serial('parent directory patterns work with gitignore option (issue #133)', async t => {
+	const temporaryParent = temporaryDirectory();
+	const temporarySrc = path.join(temporaryParent, 'src');
+	const temporaryChild = path.join(temporaryParent, 'child');
+
+	fs.mkdirSync(temporarySrc, {recursive: true});
+	fs.mkdirSync(temporaryChild, {recursive: true});
+
+	const srcFile1 = path.join(temporarySrc, 'test1.ts');
+	const srcFile2 = path.join(temporarySrc, 'test2.ts');
+
+	fs.writeFileSync(srcFile1, 'content1', 'utf8');
+	fs.writeFileSync(srcFile2, 'content2', 'utf8');
+
+	// Add a .gitignore to ensure gitignore processing is active
+	fs.writeFileSync(path.join(temporaryParent, '.gitignore'), 'node_modules\n', 'utf8');
+
+	try {
+		// Test relative parent directory pattern with gitignore:true
+		const relativeResult = await runGlobby(t, '../src/*.ts', {
+			cwd: temporaryChild,
+			gitignore: true,
+			absolute: false,
+		});
+
+		t.deepEqual(relativeResult.sort(), ['../src/test1.ts', '../src/test2.ts']);
+
+		// Test absolute paths with gitignore:true
+		const absoluteResult = await runGlobby(t, '../src/*.ts', {
+			cwd: temporaryChild,
+			gitignore: true,
+			absolute: true,
+		});
+
+		t.is(absoluteResult.length, 2);
+		t.true(absoluteResult.every(p => path.isAbsolute(p)));
+		t.true(absoluteResult.some(p => p.endsWith('test1.ts')));
+		t.true(absoluteResult.some(p => p.endsWith('test2.ts')));
+
+		// Verify it still works with gitignore:false for consistency
+		const withoutGitignoreResult = await runGlobby(t, '../src/*.ts', {
+			cwd: temporaryChild,
+			gitignore: false,
+			absolute: false,
+		});
+
+		t.deepEqual(withoutGitignoreResult.sort(), ['../src/test1.ts', '../src/test2.ts']);
+	} finally {
+		fs.rmSync(temporaryParent, {recursive: true, force: true});
+	}
+});
+
 test.serial('gitignore directory patterns stop fast-glob traversal', async t => {
 	const temporaryCwd = temporaryDirectory();
 	const gitignorePath = path.join(temporaryCwd, '.gitignore');

tests/ignore.js

@@ -655,17 +655,15 @@ test('fs option preserves context for ignore file readers', async t => {
 	t.false(syncPredicate('not-ignored.js'));
 });
 
-test('path prefix edge case - reject paths with similar prefix outside cwd', async t => {
+test('path prefix edge case - paths with similar prefix outside cwd return false', async t => {
 	const cwd = path.join(PROJECT_ROOT, 'fixtures/gitignore');
 	const isIgnored = await isGitIgnored({cwd});
 
-	// Test that paths outside the cwd but with similar prefix are rejected
-	// e.g., if cwd is /foo/bar, then /foo/barbaz should throw an error
+	// Test that paths outside the cwd but with similar prefix return false (not ignored)
+	// e.g., if cwd is /foo/bar, then /foo/barextra should not be ignored
+	// because it's outside cwd and gitignore patterns from cwd don't apply to it
 	const outsidePath = cwd + 'extra/file.js'; // Creates path like /foo/gitignoreextra/file.js
 
-	const error = t.throws(() => {
-		isIgnored(outsidePath);
-	});
-
-	t.regex(error.message, /Path .+ is not in cwd/);
+	// Should return false (not ignored) rather than throwing error
+	t.false(isIgnored(outsidePath));
 });