-
-
Notifications
You must be signed in to change notification settings - Fork 455
Closed
Labels
Description
by adding |number
to the value side of ParsedQuery, you've changed the return type in a really breaking the type signature for users who don't use parseNumbers
- now every use of this generates errors like this:
[devserver] TS2345: Argument of type 'string | number | ReactText[]' is not assignable to parameter of type 'string | string[]'.
[devserver] Type 'number' is not assignable to type 'string | string[]'.
This is only going to get worse when #183 is fixed.
I'd like to suggest either a complex typescript signature such that only passing parseNumbers
results in the new string |number| (number|string)[]
, or introduce a new function parseValues
which does the number/boolean/etc
danilofuchs and cdeutsch