Skip to content

Fix the TypeScript types #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 20, 2019
Merged

Fix the TypeScript types #185

merged 5 commits into from
Jun 20, 2019

Conversation

cdeutsch
Copy link
Contributor

We need to return different versions of ParsedQuery based on the values of parseBooleans and parseNumbers.

Not sure about the naming. A bit verbose, but....

Fixes #184

@alecf @felixoi will this work for you?

@cdeutsch
Fix types.
10ed7ba 
We need to return different versions of `ParsedQuery` based on the values of `parseBooleans` and `parseNumbers`.

Fixes sindresorhus#184
@cdeutsch
Copy link
Contributor Author

Note I also removed the readonly from ParsedQuery and its variants, because parse is not returning a readonly object. You are able to modify its results (and I do in my code). Maybe I'm missing something there?

alecf
alecf reviewed Jun 19, 2019
View reviewed changes
@sindresorhus sindresorhus changed the title Fix types Fix TypeScript types Jun 20, 2019
@cdeutsch cdeutsch closed this Jun 20, 2019
@cdeutsch cdeutsch deleted the fix-typings branch June 20, 2019 14:21
@cdeutsch cdeutsch restored the fix-typings branch June 20, 2019 14:21
@cdeutsch
Copy link
Contributor Author

Oops. Accidentally deleted the branch from my repo when cleaning up.

@cdeutsch cdeutsch reopened this Jun 20, 2019
@sindresorhus sindresorhus changed the title Fix TypeScript types Fix the TypeScript types Jun 20, 2019
@sindresorhus sindresorhus merged commit cba4c93 into sindresorhus:master Jun 20, 2019
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Mar 6, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 23, 2020
Open
This was referenced May 2, 2020
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alecf alecf alecf left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

broken types for parse

3 participants

@cdeutsch @alecf @sindresorhus