#1 Initial CircleCI support #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service in circleci config file
vsbogd
requested changes
Sep 13, 2018
.circleci/config.yml
Outdated
| git clone https://github.com/singnet/snet-daemon.git | ||
| cd snet-daemon | ||
| ./scripts/install | ||
| ./scripts/build |
There was a problem hiding this comment.
Should be ./scripts/build linux amd64, I have fixed wiki already https://github.com/singnet/wiki/wiki/Tutorial:-Build-and-deploy-SingularityNET-locally#build-snet-daemon
There was a problem hiding this comment.
I have added linux amd64 arguments for the snet-daemon building.
| cd $SINGNET_REPOS | ||
| git clone https://github.com/singnet/example-service.git | ||
| cd example-service | ||
| pip3 install -r requirements.txt No newline at end of file |
There was a problem hiding this comment.
really minor, but it is better to add newline at the end of last line
There was a problem hiding this comment.
I added the new line to the config file in the next pull request #4 which provides the integration test
vsbogd
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided CircleCI configuration setups all necessary tools for SingularityNET platform building.
It gets from git and build modules platform-contracts, snet-cli, snet-daemon, and example-service.