fpioa: Fix access granularity issues #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've had some issues where fpioa configuration was seemingly ignored; this resulted in keypresses being ignored (in `kpu_conv` and other demos) where the buttons on the Maix Go were assigned to HSGPIO >= 4. The problem is that accesses to packed structures can be optimized to byte acceses (`sbu` instructions, noticed with gcc 8.2.0) whereas the registers require 32-bit accesses. Avoid this by implementing an explicit conversion between uint32_t and the configuration structure.
|
apparently this is isn't the right solution either, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had some issues where fpioa configuration was seemingly ignored; this resulted in keypresses being ignored (in
kpu_convand other demos) where the buttons on the Maix Go were assigned to HSGPIO >= 4.The problem is that accesses to packed structures can be optimized to byte acceses (
lb,sbinstructions, noticed with gcc 8.2.0) whereas the registers require 32-bit accesses. Avoid this by implementing anexplicit conversion between uint32_t and the configuration structure.