Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed neurify, runtests passed. #95

Merged
merged 26 commits into from
Apr 25, 2020

Conversation

Wei-TianHao
Copy link
Collaborator

Fixed the Neurify's implementation based on Changliu's code. ReluVal is also modified to share some common functions with Neurify. Added a new helper function in util.jl.

Passed runtests.jl and runtests2.jl (If commented the Reluplex part).

tomerarnon and others added 20 commits June 7, 2019 09:13
remove mention of Tracker to keep up with Flux
…kshop/tensorflow-1.15.2

Bump tensorflow from 1.15.0 to 1.15.2 in /examples/cars_workshop
Avoid model recreation at every call of reluplex_step
@mykelk mykelk requested a review from tomerarnon April 20, 2020 05:29
@changliuliu changliuliu mentioned this pull request Apr 22, 2020
@tomerarnon tomerarnon changed the base branch from master to neurify April 22, 2020 05:35
@tomerarnon tomerarnon changed the base branch from neurify to master April 22, 2020 05:40
@tomerarnon tomerarnon changed the base branch from master to neurify April 22, 2020 05:44
@tomerarnon
Copy link
Collaborator

Changed the base branch of this PR to be the neurify branch as per #79 .
This introduced a few merge conflicts, so let me know if this is not the intention and we can easily reverse it!

@Wei-TianHao
Copy link
Collaborator Author

I resolved the conflicts online, it should be fine now. Please let me know if it doesn't work. Thanks

@tomerarnon
Copy link
Collaborator

tomerarnon commented Apr 23, 2020

Looks like the tests are failing (the badge isn't updating, but if you click on details you can see). It seems something may have changed in the tests themselves. Would you mind looking into what happened?

@tomerarnon tomerarnon merged commit 81f13af into sisl:neurify Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants