Skip to content

Conversation

@fabricioblz
Copy link
Contributor

#34

issues_-sistemacode_code-_code_climate

@fabricioblz
Copy link
Contributor Author

E ai @luizpicolo,

Estou subindo uma sugestão para resolver o problema do code climate.
Criei um servico que abstrai a lógica de verificar se o current_user é admin.

Se vc mergiar, eu abro um PR com os testes de integração, mas já fiz os testes de aceitação.

Vlw!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 85.714% when pulling da0e53e on fabricioblz:add-search-service into 5d54fd6 on sistemacode:master.

@luizpicolo
Copy link
Owner

Hello @fabricioblz. Alteração bem vinda 💯 . Vamos fazer assim, crie os testes juntamente com seu PR que "mergiarei" tudo junto.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 85.714% when pulling af339d6 on fabricioblz:add-search-service into 5d54fd6 on sistemacode:master.

@fabricioblz
Copy link
Contributor Author

Testes feitos @luizpicolo!

Pode revalidar.

@luizpicolo
Copy link
Owner

Thx so much @fabricioblz

@luizpicolo luizpicolo merged commit 52fc5f8 into luizpicolo:master Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants