chore(be): get selected field in workbook api #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aintbe
pushed a commit
that referenced
this pull request
Feb 22, 2023
aintbe
added a commit
that referenced
this pull request
Feb 24, 2023
* chore(be): adjust parameters in workbook module * chore(be): adjust parameters in problem module * chore(be): adjust parameters in notice module * chore(be): adjust parameters in contest module * fix(be): modify wrong imports * Merge remote-tracking branch origin/main into 365-standardize-service * fix(be): readjust to use cursor-based pagination properly * chore(be): get selected field in workbook api (#411) * fix(be): fix related tests --------- Co-authored-by: goo314 <rn0731@g.skku.edu>
eunnbi
pushed a commit
that referenced
this pull request
Feb 28, 2023
* chore(be): adjust parameters in workbook module * chore(be): adjust parameters in problem module * chore(be): adjust parameters in notice module * chore(be): adjust parameters in contest module * fix(be): modify wrong imports * Merge remote-tracking branch origin/main into 365-standardize-service * fix(be): readjust to use cursor-based pagination properly * chore(be): get selected field in workbook api (#411) * fix(be): fix related tests --------- Co-authored-by: goo314 <rn0731@g.skku.edu>
dotoleeoak
pushed a commit
that referenced
this pull request
Mar 17, 2023
* chore(be): adjust parameters in workbook module * chore(be): adjust parameters in problem module * chore(be): adjust parameters in notice module * chore(be): adjust parameters in contest module * fix(be): modify wrong imports * Merge remote-tracking branch origin/main into 365-standardize-service * fix(be): readjust to use cursor-based pagination properly * chore(be): get selected field in workbook api (#411) * fix(be): fix related tests --------- Co-authored-by: goo314 <rn0731@g.skku.edu>
dotoleeoak
added a commit
that referenced
this pull request
Mar 23, 2023
* feat: connect auth api to header view * fix: disable top-level await call in script setup * feat(fe): connect contest detail problem api (#394) * feat(fe): add contest detail problem branch * feat(fe): connect problem api with paginationtable * feat(fe): render problem api with paginationtable * fix(ci): trigger ci on pull request edit * refactor(fe): move on-mounted action to contest problem component * chore(fe): delete unnecessary field type * refactor(fe): refactor codes * refactor(fe): rename components and contest detail page & use id value * chore(fe): add todo task in problem --------- Co-authored-by: Jaemin Choi <1dotolee@gmail.com> Co-authored-by: goo314 <rn0731@g.skku.edu> * refactor(be): standardize service method structures (#412) * chore(be): adjust parameters in workbook module * chore(be): adjust parameters in problem module * chore(be): adjust parameters in notice module * chore(be): adjust parameters in contest module * fix(be): modify wrong imports * Merge remote-tracking branch origin/main into 365-standardize-service * fix(be): readjust to use cursor-based pagination properly * chore(be): get selected field in workbook api (#411) * fix(be): fix related tests --------- Co-authored-by: goo314 <rn0731@g.skku.edu> * chore(deps): update all non-major dependencies (#427) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(be): fix throw inappropriate exception (#406) * fix(be): fix throw inappropriate exception * fix(be): change exception entity-already-exists * chore(be): change exception description * chore(be): deleted unused exceptions * chore(be): delete unused exceptions * chore(be): remove unused exception in leaveGroup --------- Co-authored-by: cho-to <nicole2974@g.skku.edu> * chore(be): add id field to workbook list (#437) * fix(be): modify PublicContestController for users not logged in (#420) * fix(be): add get contest controller for guest * fix(be): add GuestContestController to module * fix(be): add grouId identification prisma query * fix(be): remove registered in guest controller * fix(be): remove prisma query grouId condition * fix(be): remove GuestContestController * fix(be): set getContests userId default as undefined * fix(be): turn back before the last commit * fix(be): set userId default as undefined * fix(be): remove getContestsByGroupId Optional * feat: add type description on imports (#438) * feat: add type description on imports * fix: add support for implicit value reference * cf. http://github.com/typescript-eslint/pull/2751 * style(be): lint using more specific analysis * fix: manually add type keyword to body types * fix(deps): update all non-major dependencies (#442) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update all non-major dependencies (#443) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * test(be): write public contest get API test code (#414) * fix(be): write public contest get API test code * fix(be): remove unused User import in test code * fix(be): add mockPrismaService test * fix(be): change method name * fix(fe): change header position on mobile screen (#445) fix: change position property value * fix(fe): adjust modal size modal에 사용된 w-fit, h-fit class와 외부에서 attribute로 넘기는 weight, height가 Tailwind에 의해 CSS 내에 정의된 순서에 따라 충돌된다. w-fit, h-fit class를 지우고, 외부에서 직접 크기나 padding 등을 지정하도록 한다. * fix(be): disable type import of dto `import type` keyword 때문에 NestJS에서 DTO 처리가 제대로 이뤄지지 않는다. TODO: E2E 테스트에서 검증하기 * fix: add fixed width to authmodal 고정된 width를 사용하지 않으면 내부 component가 로딩되기 전에 width가 갑자기 바뀌는 문제가 있다. (로딩 전에는 width 0, padding만 존재) * fix(be): fix refresh token expire time node-cache-manager의 ttl 단위인 milliseconds로 expire time을 수정한다. --------- Co-authored-by: goo314 <rn0731@g.skku.edu> Co-authored-by: SongHongBin <hbsongk@naver.com> Co-authored-by: Sori Lim <drwho@g.skku.edu> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jisoo Park <102132161+jspark2000@users.noreply.github.com> Co-authored-by: cho-to <nicole2974@g.skku.edu> Co-authored-by: Hyeongrok1 <105476324+Hyeongrok1@users.noreply.github.com> Co-authored-by: Eunbi Kang <jenabill@naver.com>
jspark2000
added a commit
that referenced
this pull request
Mar 28, 2023
* feat: connect auth api to header view * fix: disable top-level await call in script setup * feat(fe): connect contest detail problem api (#394) * feat(fe): add contest detail problem branch * feat(fe): connect problem api with paginationtable * feat(fe): render problem api with paginationtable * fix(ci): trigger ci on pull request edit * refactor(fe): move on-mounted action to contest problem component * chore(fe): delete unnecessary field type * refactor(fe): refactor codes * refactor(fe): rename components and contest detail page & use id value * chore(fe): add todo task in problem --------- Co-authored-by: Jaemin Choi <1dotolee@gmail.com> Co-authored-by: goo314 <rn0731@g.skku.edu> * refactor(be): standardize service method structures (#412) * chore(be): adjust parameters in workbook module * chore(be): adjust parameters in problem module * chore(be): adjust parameters in notice module * chore(be): adjust parameters in contest module * fix(be): modify wrong imports * Merge remote-tracking branch origin/main into 365-standardize-service * fix(be): readjust to use cursor-based pagination properly * chore(be): get selected field in workbook api (#411) * fix(be): fix related tests --------- Co-authored-by: goo314 <rn0731@g.skku.edu> * chore(deps): update all non-major dependencies (#427) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(be): fix throw inappropriate exception (#406) * fix(be): fix throw inappropriate exception * fix(be): change exception entity-already-exists * chore(be): change exception description * chore(be): deleted unused exceptions * chore(be): delete unused exceptions * chore(be): remove unused exception in leaveGroup --------- Co-authored-by: cho-to <nicole2974@g.skku.edu> * chore(be): add id field to workbook list (#437) * fix(be): modify PublicContestController for users not logged in (#420) * fix(be): add get contest controller for guest * fix(be): add GuestContestController to module * fix(be): add grouId identification prisma query * fix(be): remove registered in guest controller * fix(be): remove prisma query grouId condition * fix(be): remove GuestContestController * fix(be): set getContests userId default as undefined * fix(be): turn back before the last commit * fix(be): set userId default as undefined * fix(be): remove getContestsByGroupId Optional * feat: add type description on imports (#438) * feat: add type description on imports * fix: add support for implicit value reference * cf. http://github.com/typescript-eslint/pull/2751 * style(be): lint using more specific analysis * fix: manually add type keyword to body types * fix(deps): update all non-major dependencies (#442) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update all non-major dependencies (#443) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * test(be): write public contest get API test code (#414) * fix(be): write public contest get API test code * fix(be): remove unused User import in test code * fix(be): add mockPrismaService test * fix(be): change method name * fix(fe): change header position on mobile screen (#445) fix: change position property value * fix(fe): adjust modal size modal에 사용된 w-fit, h-fit class와 외부에서 attribute로 넘기는 weight, height가 Tailwind에 의해 CSS 내에 정의된 순서에 따라 충돌된다. w-fit, h-fit class를 지우고, 외부에서 직접 크기나 padding 등을 지정하도록 한다. * fix(be): disable type import of dto `import type` keyword 때문에 NestJS에서 DTO 처리가 제대로 이뤄지지 않는다. TODO: E2E 테스트에서 검증하기 * fix: add fixed width to authmodal 고정된 width를 사용하지 않으면 내부 component가 로딩되기 전에 width가 갑자기 바뀌는 문제가 있다. (로딩 전에는 width 0, padding만 존재) * fix(be): fix refresh token expire time node-cache-manager의 ttl 단위인 milliseconds로 expire time을 수정한다. --------- Co-authored-by: goo314 <rn0731@g.skku.edu> Co-authored-by: SongHongBin <hbsongk@naver.com> Co-authored-by: Sori Lim <drwho@g.skku.edu> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jisoo Park <102132161+jspark2000@users.noreply.github.com> Co-authored-by: cho-to <nicole2974@g.skku.edu> Co-authored-by: Hyeongrok1 <105476324+Hyeongrok1@users.noreply.github.com> Co-authored-by: Eunbi Kang <jenabill@naver.com>
Kohminchae
pushed a commit
that referenced
this pull request
Jun 15, 2023
* feat(fe): connect group contest list get api * feat(fe): connect contest detail problem api (#394) * feat(fe): add contest detail problem branch * feat(fe): connect problem api with paginationtable * feat(fe): render problem api with paginationtable * fix(ci): trigger ci on pull request edit * refactor(fe): move on-mounted action to contest problem component * chore(fe): delete unnecessary field type * refactor(fe): refactor codes * refactor(fe): rename components and contest detail page & use id value * chore(fe): add todo task in problem --------- Co-authored-by: Jaemin Choi <1dotolee@gmail.com> Co-authored-by: goo314 <rn0731@g.skku.edu> * refactor(be): standardize service method structures (#412) * chore(be): adjust parameters in workbook module * chore(be): adjust parameters in problem module * chore(be): adjust parameters in notice module * chore(be): adjust parameters in contest module * fix(be): modify wrong imports * Merge remote-tracking branch origin/main into 365-standardize-service * fix(be): readjust to use cursor-based pagination properly * chore(be): get selected field in workbook api (#411) * fix(be): fix related tests --------- Co-authored-by: goo314 <rn0731@g.skku.edu> * chore(deps): update all non-major dependencies (#427) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(be): fix throw inappropriate exception (#406) * fix(be): fix throw inappropriate exception * fix(be): change exception entity-already-exists * chore(be): change exception description * chore(be): deleted unused exceptions * chore(be): delete unused exceptions * chore(be): remove unused exception in leaveGroup --------- Co-authored-by: cho-to <nicole2974@g.skku.edu> * refactor(fe): use useDateFormat composable * Revert "refactor(fe): use useDateFormat composable" This reverts commit 5aac277. * refactor(fe): update time info function * chore(fe): remove ago string --------- Co-authored-by: SongHongBin <hbsongk@naver.com> Co-authored-by: Jaemin Choi <1dotolee@gmail.com> Co-authored-by: goo314 <rn0731@g.skku.edu> Co-authored-by: Sori Lim <drwho@g.skku.edu> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jisoo Park <102132161+jspark2000@users.noreply.github.com> Co-authored-by: cho-to <nicole2974@g.skku.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
workbook을 가져오는 api에 id, title만 가져오는 select option을 추가했습니다.
admin과 user이 같은 service를 사용하기 때문에 추후에 구분할 필요가 있을 것 같습니다.
(admin이 user보다 더 많은 정보를 요구할 수 있기 때문)
close #392
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).