Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Let the user define the keyboard shortcuts #1479

Closed
komen205 opened this issue May 8, 2022 · 2 comments
Closed

[feature] Let the user define the keyboard shortcuts #1479

komen205 opened this issue May 8, 2022 · 2 comments
Labels
GUI Issues in jadx-gui module new feature
Milestone
TBD

Comments

@komen205
Copy link

komen205 commented May 8, 2022

I'd love to be able to change my keyboard shortcuts. And I think this would benefit other people.

For example: to go back the default key is the "escape" however it'd be nice to change it to Control + Z. Which is the key that most IDE's use.
@komen205 komen205 changed the title [feature] Let the user defined himself the keyboard shortcuts [feature] Let the user define himself the keyboard shortcuts May 8, 2022
@komen205 komen205 changed the title [feature] Let the user define himself the keyboard shortcuts [feature] Let the user define the keyboard shortcuts May 8, 2022
@yfy-1997
Copy link

it's a good idea!

@skylot skylot added the GUI Issues in jadx-gui module label May 18, 2022
@skylot skylot added this to the TBD milestone May 18, 2022
@skylot skylot mentioned this issue Nov 3, 2022
Closed
@Mino260806 Mino260806 mentioned this issue Aug 2, 2023
Merged
skylot added a commit that referenced this issue Aug 3, 2023
@Mino260806 @skylot
feat(gui): allow user to set custom shortcuts (#1479)(PR #1980)
68b84ea 
* feat(gui): allow user to customize shortcuts

* internal: fixed other constructor for jadx action

* make code area actions customizable

* show warning dialog when mouse button is commonly used

* applied code formatting

* code formatting and and moved string to resources

* moved action related classes to their own package

* added fix for actions with modifiers in macos

* ignore left click in shortcut edit

* applied code formatting

* warn user when a duplicate shortcut is entered

* save shortcut when key is pressed (instead of typed)

* fix node under mouse being ignored

Co-authored-by: skylot <118523+skylot@users.noreply.github.com>

* add missing import

* applied code formatting

* added custom shortcuts support to script content panel

* save shortcut when key is released (instead of pressed)

* enable custom shortcut in script autocomplete

* fix duplicate shortcut warning when the shortcut is set again at the same action

* fixed mouse buttons shortcut not working for code area

* fix exception with mouse button shortcuts

* fix action getting fired twice

* added variants for forward and back nav actions

* fix exception when shortcut is not saved

* fix mouse button shortcut for auto complete action

* consume mouse event if bound to an action

* workaround not being able to extend HashMap

* fix exception in script code area when using mouse button shortcut

* minor pref serialiazation improvement

* fix action buttons not working (like run action)

* fix exception with plugin actinos

* fixed nullptr when adding an action with null actionmodel to jadxmenu

* fix plugin action name not showing

---------

Co-authored-by: skylot <118523+skylot@users.noreply.github.com>
@skylot
Copy link
Owner

skylot commented Aug 3, 2023

Shortcuts customization implemented by @Mino260806 in PR #1980.

@skylot skylot closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GUI Issues in jadx-gui module new feature
Projects
None yet
Milestone
TBD
Development

No branches or pull requests
3 participants
@skylot @yfy-1997 @komen205