-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to @libsql/client to support remote database connections #4
Conversation
Still need to test this with new & existing labelers to make sure it doesn't break anything |
Managed to do some testing locally, was able to verify backwards compatibility with reading and writing to Issues found while testing remote connections:
@futurGH I'm currently wresting with the idea of introducing an async |
Neat! Sorry I haven't had a chance to take a look at this yet, hoping to get to it this weekend.
I think the least breaking option here would be to introduce a |
Agreed, done! Also added a warning when the server fails to set the |
18ec234
to
cef8b92
Compare
Finally getting a chance to take a look at this — is it ready for review? |
Yep, should be ready for review! Working on a separate PR to update the documentation as well |
Thanks! Will publish in 0.2.0. |
Problem
When deploying the labeler server on container platforms with ephemeral file systems (e.g., Heroku, Railway), the SQLite database file would get deleted on each deploy since the filesystem is not persistent. This makes it difficult to maintain label history across deployments
Solution
The @libsql/client supports both local SQLite files and remote database connections. This PR updates the labeler server to:
@libsql/client
url
- Remote database URL (e.g., "libsql://your-db.skyware.js.org")authToken
- Authentication token for remote databaseUsage