Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the OAuth module to the latest #1802

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 13, 2023

Summary

This pull request upgrades the OAuth module to the latest (slackapi/node-slack-sdk#1605) and add HTML escape code for the developer mode. Since there is actually no possible way to inject parameters to the web page content generated by bolt-js, we don't need to release a new patch version immediately. This upgrade is just for preventing future issues.

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality dependencies Pull requests that update a dependency file labels Apr 13, 2023
@seratch seratch added this to the 3.13.1 milestone Apr 13, 2023
@seratch seratch self-assigned this Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@0f90200). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Current head 968371f differs from pull request most recent head c879904. Consider uploading reports for the commit c879904 to get more accurate results

@@           Coverage Diff           @@
##             main    #1802   +/-   ##
=======================================
  Coverage        ?   82.11%           
=======================================
  Files           ?       18           
  Lines           ?     1526           
  Branches        ?      442           
=======================================
  Hits            ?     1253           
  Misses          ?      175           
  Partials        ?       98           
Impacted Files Coverage Δ
src/App.ts 83.75% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit af58002 into slackapi:main Apr 13, 2023
@seratch seratch deleted the oauth-module-upgrade branch April 13, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant