Skip to content

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Jul 14, 2021

This pull request fixes #400 by adding token rotation feature support.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.7.0 milestone Jul 14, 2021
@seratch seratch changed the title @seratch Fix #400 token rotation feature support Fix #400 token rotation feature support Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #404 (135c03c) into main (1b4eefc) will decrease coverage by 0.36%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   91.72%   91.36%   -0.37%     
==========================================
  Files         167      167              
  Lines        5437     5488      +51     
==========================================
+ Hits         4987     5014      +27     
- Misses        450      474      +24     
Impacted Files Coverage Δ
...ck_bolt/adapter/aws_lambda/lambda_s3_oauth_flow.py 97.14% <ø> (ø)
slack_bolt/oauth/async_oauth_flow.py 90.75% <ø> (ø)
slack_bolt/oauth/oauth_flow.py 90.43% <ø> (ø)
slack_bolt/authorization/async_authorize.py 79.16% <45.45%> (-7.57%) ⬇️
slack_bolt/authorization/authorize.py 78.99% <47.82%> (-7.47%) ⬇️
slack_bolt/app/app.py 87.87% <100.00%> (+0.02%) ⬆️
slack_bolt/app/async_app.py 94.14% <100.00%> (+0.01%) ⬆️
slack_bolt/oauth/async_oauth_settings.py 100.00% <100.00%> (ø)
slack_bolt/oauth/oauth_settings.py 100.00% <100.00%> (ø)
slack_bolt/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4eefc...135c03c. Read the comment docs.

@seratch seratch merged commit eb237ad into slackapi:main Jul 15, 2021
@seratch seratch deleted the issue-400-token-rotation branch July 15, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add token rotation feature support

1 participant