Skip to content

Fix #409 Custom token rotation expiration time does not work if installation_store is passed at top level #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Fix #409 Custom token rotation expiration time does not work if installation_store is passed at top level #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions slack_bolt/app/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,9 @@ def message_hello(message, say):
)
if self._authorize is None:
self._authorize = self._oauth_flow.settings.authorize
self._authorize.token_rotation_expiration_minutes = (
oauth_settings.token_rotation_expiration_minutes
)

if (
self._installation_store is not None or self._authorize is not None
Expand Down
3 changes: 3 additions & 0 deletions slack_bolt/app/async_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,9 @@ async def message_hello(message, say): # async function
)
if self._async_authorize is None:
self._async_authorize = self._async_oauth_flow.settings.authorize
self._async_authorize.token_rotation_expiration_minutes = (
oauth_settings.token_rotation_expiration_minutes
)

if (
self._async_installation_store is not None
Expand Down