Skip to content

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Sep 7, 2021

This pull request fixes #459. Refer to the issue for details.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added bug Something isn't working area:async area:sync labels Sep 7, 2021
@seratch seratch added this to the 1.9.1 milestone Sep 7, 2021
@seratch seratch self-assigned this Sep 7, 2021
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #460 (db30f04) into main (568c168) will not change coverage.
The diff coverage is n/a.

❗ Current head db30f04 differs from pull request most recent head 59516e3. Consider uploading reports for the commit 59516e3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files         167      167           
  Lines        5523     5523           
=======================================
  Hits         5049     5049           
  Misses        474      474           
Impacted Files Coverage Δ
slack_bolt/app/app.py 87.64% <ø> (ø)
slack_bolt/app/async_app.py 94.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568c168...59516e3. Read the comment docs.

@seratch seratch merged commit a388546 into slackapi:main Sep 7, 2021
@seratch seratch deleted the issue-459-type-hint-errors branch September 7, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:async area:sync bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App decorator methods (e.g., action, command) have incorrect return type annotation

1 participant