Enhance AuthorizeResult to have bot/user_scopes & resolve user_id for user token #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e (optional) Also, this commit fixes the bug where authorize_result.user_id is not resolved when both bot and user tokens exist.
Codecov Report
@@ Coverage Diff @@
## main #855 +/- ##
==========================================
- Coverage 92.10% 92.03% -0.08%
==========================================
Files 181 181
Lines 6095 6137 +42
==========================================
+ Hits 5614 5648 +34
- Misses 481 489 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seratch
added a commit
to seratch/bolt-python
that referenced
this pull request
Mar 13, 2023
8 tasks
seratch
added a commit
that referenced
this pull request
Mar 13, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances
AuthorizeResultto havebot_scopesanduser_scopeswhen they're available. For backward-compatibility, they are totally optional. The built-in authorize tries to set the properties as much as possible, but it's still fine to omit these two properties.Also, this commit fixes the bug where authorize_result.user_id is not resolved when both bot and user tokens exist.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.