Allow requests to both slack.com and api.slack.com when running in local mode #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 95.08% 95.09%
=======================================
Files 14 14
Lines 549 550 +1
Branches 82 82
=======================================
+ Hits 522 523 +1
Misses 27 27 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: slackapi/deno-slack-sdk#254
For local run mode, we, by default, allow network access to slack.com. However, this does not explicitly allow api.slack.com. Some of our APIs, like the SCIM APIs, are available at api.slack.com/scim. So today, developers can't access these APIs when running in local run mode.
Let's fix that!
I checked with the run-on-slack team, and tested this for deployed apps, and this is already allowed there. So this lines up local-run behaviour with deployed behaviour.