Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

robot.messageRoom(chan, msg) doesn't work if chan starts with "#" #136

Closed
yozlet opened this issue Dec 31, 2014 · 4 comments
Closed

robot.messageRoom(chan, msg) doesn't work if chan starts with "#" #136

yozlet opened this issue Dec 31, 2014 · 4 comments
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented

Comments

@yozlet
Copy link

yozlet commented Dec 31, 2014

... which wouldn't be a problem if it hadn't worked in v2, but it did, and it took a while to work out why one of my scripts wasn't working any more.
@evansolomon evansolomon added the bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented label Dec 31, 2014
@yozlet yozlet mentioned this issue Dec 31, 2014
Closed
@yozlet
Copy link
Author

yozlet commented Dec 31, 2014

The problem is in slack-client, so I added a PR there: slackapi/node-slack-sdk#9

shokai added a commit to shokai/hubot-slack that referenced this issue Jan 9, 2015
@shokai
replace "#" from channel name prefix slackapi#136
34e0614
@shokai shokai mentioned this issue Jan 9, 2015
Closed
@trodrigues
Copy link

Any idea when we'll see the slack-client version updated here to fix this?

@paulhammond
Copy link
Contributor

Pretty soon - we'll need to bump the version when we merge #148, so I'll likely do it at the same time

@miyagawa miyagawa mentioned this issue Feb 19, 2015
Closed
@technicalpickles
Copy link
Contributor

#148 was merged, so this can be closed.

@DEGoodmanWilson DEGoodmanWilson mentioned this issue Jun 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@technicalpickles @paulhammond @trodrigues @yozlet @evansolomon @DEGoodmanWilson