Skip to content

Conversation

ecstrema
Copy link
Contributor

@ecstrema ecstrema commented May 16, 2021

Currently, keeping right pressed does nothing more than just pressing it once. The event should auto repeat if the key combination is still pressed.
This PR is an untested work. I have not built slidev, I just wanted to try it out and ask if you thought it was a good idea. I actually modified the code in github's default, so it might not even build. If you think that the idea is worth a bit of work I will put it.

ecstrema and others added 2 commits May 16, 2021 02:28
Currently, keeping right pressed does nothing more than just pressing it once. The event should auto repeat if the key combination is still pressed. 
This PR is an untested work. I have not built slidev, I just wanted to try it out and ask if you thought it was a good idea. I actually modified the code in github's default, so it might not even build.
@antfu antfu changed the title Add autoRepeating shortcuts feat: shortcuts auto repeating May 17, 2021
@antfu antfu merged commit 902904d into slidevjs:main May 17, 2021
@ecstrema
Copy link
Contributor Author

Great to see there was some interest;)

antfu pushed a commit that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants