Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnnotationScannerFactory is hard coded to load AnnotationScanner instances from the TCCL. #404

Closed
pferraro opened this issue Jul 16, 2020 · 2 comments · Fixed by #413 or #419
Closed

AnnotationScannerFactory is hard coded to load AnnotationScanner instances from the TCCL. #404

pferraro opened this issue Jul 16, 2020 · 2 comments · Fixed by #413 or #419
Assignees
@phillip-kruger
Milestone
2.0.6

Comments

@pferraro
Copy link
Contributor

OpenApiProcessor.modelFromAnnotations(...) creates a new OpenApiAnnotationScanner instance which currently loads AnnotationScanner instances from the TCCL. Given that smallrye has no control which thread will call this method, it cannot assume that the intended annotation scanner instances (or indeed, if any) will be loadable from the TCCL.

Ideally OpenApiProcessor.modelFromAnnotations(...) should accept a ClassLoader instance from which to load AnnotationScanner instances.
@phillip-kruger phillip-kruger self-assigned this Jul 24, 2020
@phillip-kruger phillip-kruger added this to the 2.0.5 milestone Jul 24, 2020
@phillip-kruger phillip-kruger mentioned this issue Jul 24, 2020
Merged
@pferraro
Copy link
Contributor Author

@phillip-kruger I don't think this fix is sufficient. AnnotationScannerFactory still loads AnnotationScanner instances using the TCCL, instead of the classloader passed to the OpenApiProcessor.modelFromAnnotations(...) method. See:
https://github.com/smallrye/smallrye-open-api/blob/master/core/src/main/java/io/smallrye/openapi/runtime/scanner/spi/AnnotationScannerFactory.java#L19

@phillip-kruger
Copy link
Member

Thanks, I'll look again in the morning

@pferraro pferraro mentioned this issue Jul 28, 2020
Merged
@phillip-kruger phillip-kruger modified the milestones: 2.0.5, 2.0.6 Jul 29, 2020
pferraro added a commit to pferraro/wildfly that referenced this issue Jul 31, 2020
@pferraro
Drop workaround for smallrye/smallrye-open-api#404
b895ffa
pferraro added a commit to pferraro/wildfly that referenced this issue Jul 31, 2020
@pferraro
Drop workaround for smallrye/smallrye-open-api#404
db0001b
@pferraro pferraro mentioned this issue Jul 31, 2020
Merged
pferraro added a commit to pferraro/wildfly that referenced this issue Aug 5, 2020
@pferraro
Drop workaround for smallrye/smallrye-open-api#404
afd3465
pferraro added a commit to pferraro/wildfly that referenced this issue Aug 6, 2020
@pferraro
Drop workaround for smallrye/smallrye-open-api#404
9149289
jamezp added a commit to jamezp/wildfly that referenced this issue Aug 12, 2020
@jamezp
Merged pull request wildfly#13441
009e154 
Drop workaround for smallrye/smallrye-open-api#404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillip-kruger phillip-kruger

Labels
None yet
Projects
None yet
Milestone
2.0.6
2 participants
@pferraro @phillip-kruger