Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load AnnotationScanner instances from the designated classloader. #419

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Load AnnotationScanner instances from the designated classloader. #419

merged 1 commit into from
Jul 28, 2020

Conversation

pferraro
Copy link
Contributor

Fixes #404

phillip-kruger
phillip-kruger approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks:) I was just about to do a PR with the same fix:)

@phillip-kruger phillip-kruger merged commit ec22101 into smallrye:master Jul 28, 2020
@phillip-kruger phillip-kruger added this to the 2.0.6 milestone Jul 28, 2020
@phillip-kruger
Copy link
Member

@pferraro - how urgent is this for you ? Do you need a release ?

@pferraro
Copy link
Contributor Author

It's not super urgent since it has a workaround, i.e. setting the TCCL explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.6
Development

Successfully merging this pull request may close these issues.

AnnotationScannerFactory is hard coded to load AnnotationScanner instances from the TCCL.
2 participants
@pferraro @phillip-kruger