Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did as we discussed here #101
Also added an example how it could be with functions, so functions would be properly wrapped and less reasons to use
Expression\Raw
. But naming convention in Clickhouse is not same as in PSR. So Class(and file) names should differ, I think. But callExpression\Function\UuidStringToNum($uuid)
is not that clear, IMO. Another option is to alter it toExpression\Function('UUIDStringToNum', $uuid)
. It should cover all such cases, but will be less strict and, probably, less clear.By the way, found that I'm not a contributor here https://github.com/smi2/phpClickHouse/graphs/contributors
after #101 was merged.
Is it by design or just a merging error? Besides that I needed code from #101 into master, so I could stop using fork in my projects and switch to the main repo, having visible contributions to other projects is a nice reward and really helps in career building.