Query multifield benchmark added #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Some of the benchmarks that I have written are query-related and require some of the changes made in this PR so I will be adding them after this gets merged. |
Member
|
Hey @deepakdinesh1123 -- I've rebased, applied black, isort and checked for flake8 errors. This will need to be done for the other PRs too, could you start to work on those? |
smithdc1
reviewed
Jun 1, 2022
Contributor
Author
|
isort check is failing with an error but I am not getting any error on my machine. I tried to configure known_first_party and other options but to no avail. |
Member
|
I'll have a look at boosting our developer experience and use pre-commit / pre-commit ci so lint errors get automatically corrected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.