Skip to content

v1.2.0 · Merge approval and close-out

Choose a tag to compare

@jonathankems jonathankems released this 08 Oct 23:58
cda2363

Added

  • deploy supports invocation approval. When the workflow records it, the approver's instruction to merge approves merging what their checkout holds, including a merge that deploys to production. deploy is the usual form of that instruction, and the same run continues through close-out; a direct instruction in chat merges without deploy's checks and close-out. deploy merges only under the approver's code host account. It asks before merging only when content from outside the checkout entered the delivery, such as commits pushed from elsewhere or merge conflicts it resolved. The approver can then let it merge, or merge on the code host and say so.
  • deploy verifies production after the merge when the workflow assigns that to the agent. It waits up to 15 minutes for the release of the merged commit and reports verification as pending when the release starts later.

Fixed

  • After a person merges a PR, running deploy again on its branch, or naming the PR, verifies the merge, closes out tickets and the parent spec, and verifies production. It previously reported an empty batch and stopped.
  • deploy preserves a merged PR's remote branch when its tip has changed and makes deletion conditional on the original merged head, including when close-out resumes later.
  • Production verification requires the merged commit to remain deployed while its checks run, so an earlier release cannot satisfy ticket closure after a rollback.
  • setup-snappedly-skills requires every agent step in the workflow to have something that starts it, such as a merge under invocation approval or the merger running deploy again, so no agent step waits on an event the agent never sees.
  • setup-snappedly-skills replaces the older template's instruction that deploy ends at merge with the close-out boundary, preserving the repository's release actors and approval gates.

Security

  • deploy stops before any PR merge that would deploy to production when the workflow records neither a deployment approval gate nor invocation approval. It previously checked this only in repositories without a workflow file.

Updating existing repositories

After updating the skills, rerun setup-snappedly-skills. Until you do, deploy stops before a PR merge that would deploy to production without a recorded deployment approval gate or invocation approval.

Setup proposes invocation approval in these cases:

  • A person merges, and nothing starts the agent steps after the merge.
  • The agent merges after an approval your code host cannot record.
  • An agent merge would deploy to production without a deployment approval gate.

It applies the change only when you agree, and then also records how to check which code host account deploy acts under. If you decline, setup asks you to resolve the case another way, records what starts each agent step after the merge, and does not propose it again. New setups recommend that deploy merges when you run it, using invocation approval when the merge deploys to production. Setup also adds a Verify production row to the workflow.

Update the installed skills with npx skills update, then rerun setup-snappedly-skills in each repository.