Skip to content

Conversation

igneel64
Copy link
Contributor

Properly prevent vid (sessionIndex) from being set as NaN.

fix #1204

@igneel64 igneel64 requested a review from matus-tomlein June 15, 2023 08:03
@bundlemon
Copy link

bundlemon bot commented Jun 15, 2023

BundleMon

Files added (6)
Status Path Size Limits
libraries/browser-tracker-core/dist/index.mod
ule.js
+24.88KB 25KB / +10%
trackers/javascript-tracker/dist/sp.js
+24.02KB 25KB / +10%
trackers/javascript-tracker/dist/sp.lite.js
+14.69KB 15KB / +10%
trackers/browser-tracker/dist/index.umd.min.j
s
+14.53KB 15KB / +10%
libraries/tracker-core/dist/index.module.js
+13.35KB 15KB / +10%
trackers/browser-tracker/dist/index.module.js
+3.46KB 5KB / +10%

Total files change +94.92KB 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

@igneel64 igneel64 changed the base branch from master to release/3.12.1 June 15, 2023 08:36
@igneel64 igneel64 merged commit d131ebd into release/3.12.1 Jun 15, 2023
@igneel64 igneel64 deleted the fix/1204-properly-prevent-NaN-vid branch June 15, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vid is being set to NaN in recent tracker version
2 participants