testing API key parser

Author: david-schrenker

src/SocketLabs/InjectionApi/Core/ApiKeyParseResult.cs

@@ -1,4 +1,8 @@
-namespace SocketLabs.InjectionApi.Core
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace SocketLabs.InjectionApi.Core
 {
     /// <summary>
     /// A code describing the result of an attempt to parse an Api key.
@@ -11,6 +15,15 @@ public enum ApiKeyParseResult
         /// </summary>
         None,
         /// <summary>
+        /// The key length was found.
+        /// </summary>
+        InvalidKeyLength,
+
+        /// <summary>
+        /// The key format was found.
+        /// </summary>
+        InvalidKeyFormat,
+        /// <summary>
         /// The key was found to be blank or invalid.
         /// </summary>
         InvalidEmptyOrWhitespace,
@@ -23,6 +36,14 @@ public enum ApiKeyParseResult
         /// </summary>
         InvalidUnableToExtractSecretPart,
         /// <summary>
+        /// The public portion of the key is the incorrect length.
+        /// </summary>
+        InvalidPublicPartLength,
+        /// <summary>
+        /// The secret portion of the key is the incorrect length.
+        /// </summary>
+        InvalidSecretPartLength,
+        /// <summary>
         /// Key was successfully parsed.
         /// </summary>
         Success

src/SocketLabs/InjectionApi/Core/ApiKeyParser.cs

@@ -16,17 +16,31 @@ public ApiKeyParseResult Parse(string wholeApiKey)
         {
             if (string.IsNullOrWhiteSpace(wholeApiKey))
                 return ApiKeyParseResult.InvalidEmptyOrWhitespace;
-            
+
+            if (wholeApiKey.Length != 61)
+                return ApiKeyParseResult.InvalidKeyLength;
+
+            if (wholeApiKey.IndexOf(".", StringComparison.Ordinal) == -1)
+                return ApiKeyParseResult.InvalidKeyFormat;
+
             //extract public part
             var maxCount = Math.Min(50, wholeApiKey.Length);
             var publicPartEnd = wholeApiKey.IndexOf('.', startIndex: 0, maxCount); //don't check more than 50 chars
             if (publicPartEnd == -1)
                 return ApiKeyParseResult.InvalidUnableToExtractPublicPart;
-            
+
+            var publicPart = wholeApiKey.Substring(0, publicPartEnd);
+            if (publicPart.Length != 20)
+                return ApiKeyParseResult.InvalidPublicPartLength;
+
             //now extract the private part
             if (wholeApiKey.Length <= publicPartEnd + 1)
                 return ApiKeyParseResult.InvalidUnableToExtractSecretPart;
 
+            var privatePart = wholeApiKey.Substring(publicPartEnd + 1);
+            if (privatePart.Length != 40)
+                return ApiKeyParseResult.InvalidSecretPartLength;
+
             //success
             return ApiKeyParseResult.Success;
         }