Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async functions are stringified #113

Closed
nichoth opened this issue Oct 11, 2023 · 1 comment · Fixed by #114
Closed

Async functions are stringified #113

nichoth opened this issue Oct 11, 2023 · 1 comment · Fixed by #114
Assignees
@bcomnes
Labels
BUG Something isn't working

Comments

@nichoth
Copy link
Contributor

nichoth commented Oct 11, 2023 •
edited
Loading

Bug report

Link to a working example, because we pass a function that is synchronous: https://jsfiddle.net/k3prLfcd/

Passing an async function results in the function being stringified. It should be usable as a function. Link to example demonstrating the issue: https://jsfiddle.net/ope5y79f/1/

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to https://jsfiddle.net/ope5y79f/1/
  2. Click on the button
  3. See error

Expected behavior
Should be able to call async methods

Actual behavior
Async functions are stringified

Screenshots

image

Desktop (please complete the following information):

  • Browser chrome
  • Version 117.0.5938.149 (Official Build) (arm64)
@lamiazar lamiazar added the BUG Something isn't working label Oct 11, 2023
nichoth added a commit to substrate-system/tonic that referenced this issue Oct 11, 2023
@nichoth
fix socketsupply#113 - async functions
bea97c5
@nichoth nichoth mentioned this issue Oct 11, 2023
Merged
bcomnes pushed a commit that referenced this issue Oct 11, 2023
@nichoth @bcomnes
fix #113 - async functions
916fbb6
bcomnes pushed a commit to substrate-system/tonic that referenced this issue Oct 11, 2023
@nichoth @bcomnes
fix socketsupply#113 - async functions
ec7b615
bcomnes pushed a commit that referenced this issue Oct 11, 2023
@nichoth
Fix async functions (#114)
811461f 
* add a failing test

* fix #113 - async functions
@bcomnes
Copy link
Contributor

bcomnes commented Oct 11, 2023

https://github.com/socketsupply/tonic/releases/tag/v15.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcomnes bcomnes

Labels
BUG Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix async functions substrate-system/tonic
3 participants
@bcomnes @nichoth @lamiazar