Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async functions #114

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fix async functions #114

merged 2 commits into from
Oct 11, 2023

Conversation

nichoth
Copy link
Contributor

@nichoth nichoth commented Oct 11, 2023 •
edited
Loading

  • Add a failing test for async functions.
  • Add a case, '[object AsyncFunction]':

Now async functions are ok. Fix #113

@nichoth nichoth changed the title Fix async Fix async functions Oct 11, 2023
bcomnes
bcomnes approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. @heapwolf or @chicoxyzzy any thoughts?

@bcomnes bcomnes self-assigned this Oct 11, 2023
@bcomnes
Copy link
Contributor

bcomnes commented Oct 11, 2023

Going to rebase this to runt tests.

@bcomnes bcomnes merged commit 811461f into socketsupply:master Oct 11, 2023
1 check passed
@nichoth nichoth deleted the fix-async branch October 12, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcomnes bcomnes bcomnes approved these changes

@chicoxyzzy chicoxyzzy Awaiting requested review from chicoxyzzy

@heapwolf heapwolf Awaiting requested review from heapwolf

Assignees

@bcomnes bcomnes

@nichoth nichoth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async functions are stringified
2 participants
@nichoth @bcomnes