Try to rework the mail setup #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still a weird thing where it has a single string for both setting the FROM for the message and the SMTP username, which might also need to change, but now it sets mail.smtp _and_ mail.smtps properties as relevant to whether or not it's planning to use SSL, and only does auth if a password is provided.
saraid
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still a weird thing where it has a single string for both setting the FROM for the message and the SMTP username, which might also need to change, but now it sets mail.smtp and mail.smtps properties as relevant to whether or not it's planning to use SSL, and only does auth if a password is provided.