dedicatedhost cancel, cancel-guests, and list-guests commands #1075
Conversation
…ded and some unittests
|
It failed due to my latest commit, I will fix it |
| """ | ||
| return self.host.deleteObject(id=host_id) | ||
|
|
||
| def cancel_guests(self, host_id): |
There was a problem hiding this comment.
For this function, I'd like it to be able to return a structure that has a bit more information about what guests were canceled so the slcli can print out a receipt.
Ideally id, FQDN, and whether the guest was canceled or got an error
return = [
{'id': 1234, 'fqdn': 'test01.test.com', 'status': 'canceled' },
{'id': 1235, 'fqdn': 'test02.test.com', 'status': 'Exception: Running Transaction or something' },
]
There was a problem hiding this comment.
Done, it returns a dictionary and it is empty if there isn't any guest in the dedicated host. The slcli prints a table or a message in case the dict is empty.
SoftLayer/managers/dedicated_host.py
Outdated
|
|
||
| if guests: | ||
| for vs in guests: | ||
| result = self.guest.deleteObject(id=vs['id']) |
There was a problem hiding this comment.
Need to wrap this in a try/catch for SoftLayer.Exceptions. I can see a case where one guest will have a running transaction and won't be able to be canceled. So we don't want this command to fail midway.
There was a problem hiding this comment.
Done, is in the method called _delete_guest. I also added a unit-test to verify the exception message is retrieved in case the deleteObject fails
| if not (env.skip_confirmations or formatting.no_going_back(host_id)): | ||
| raise exceptions.CLIAbort('Aborted') | ||
|
|
||
| result = dh_mgr.cancel_guests(host_id) |
There was a problem hiding this comment.
After updated the manager function, just add a way to print out a nice table with the results of each guests' cancelation.
There was a problem hiding this comment.
Done. It prints a table like below
$ slcli --really dh cancel-guests 33333
:..........:...........................:..................................................................:
: id : server name : status :
:..........:...........................:..................................................................:
: 1111111 : foobar.softlayer.com : Cancelled :
: 2222222 : wombat.softlayer.com : Exception: A billing item is required to process a cancellation. :
:..........:...........................:..................................................................:
3 participants
slcli dh cancelmakes a simple call to the deleteObject method of dedicated host.slcli dh cancel-guestscancels all guests into the dedicated hostsslcli dh list-guestslists guests in the dedicated host, it should be possible to filter, sortby and display more columns in the tableIt should cover the request #1041