Implementation for volume-counting #819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented replica-locations and replica-partners for improved Experience when replicating or looking up information on replicants.
The CLI doc still had some old commands in it, so those have been removed. There have also been new commands added to slcli that weren't reflected in the doc.
…eed to be resolved now
| 'activeTransactionCount' | ||
| 'activeTransactionCount', | ||
| 'replicationPartnerCount', | ||
| ',replicationPartners[id,username,' |
There was a problem hiding this comment.
"," at the start and end of the lines are not needed, as they are added by the join at the botton
| ] | ||
| kwargs['mask'] = ','.join(items) | ||
|
|
||
| # Retrieve relevant replicant information to be displayed. |
There was a problem hiding this comment.
These items are already in the mask above. Remove this section.
| 'serviceResourceBackendIpAddress', | ||
| 'activeTransactionCount', | ||
| 'fileNetworkMountAddress' | ||
| 'fileNetworkMountAddress', |
There was a problem hiding this comment.
Same comments as the block section
|
|
||
| file_manager = SoftLayer.FileStorageManager(env.client) | ||
| file_volumes = file_manager.list_file_volumes(datacenter=datacenter, | ||
| mask=columns.mask()) |
There was a problem hiding this comment.
instead of modifying the mask in the manager, just do something like this. fix the line width so tox doesn't complain about it too.
mask = "mask[serviceResource[datacenter[name]],replicationPartners[serviceResource[datacenter[name]]]]"
block_volumes = block_manager.list_block_volumes(datacenter=datacenter,
mask=mask)
| def cli(env, sortby, columns, datacenter): | ||
| """List number of block storage volumes per datacenter.""" | ||
| block_manager = SoftLayer.BlockStorageManager(env.client) | ||
| block_volumes = block_manager.list_block_volumes(datacenter=datacenter, |
There was a problem hiding this comment.
same comment as in the file volume-count CLI command
Merged
|
Work from this pull request is continued in #856. |
allmightyspiff
pushed a commit
to allmightyspiff/softlayer-python
that referenced
this pull request
Aug 9, 2017
allmightyspiff
pushed a commit
to allmightyspiff/softlayer-python
that referenced
this pull request
Aug 9, 2017
allmightyspiff
pushed a commit
to allmightyspiff/softlayer-python
that referenced
this pull request
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 new commands:
slcli block volume-count
slcli file volume-count
improved display of information in block and file volume-list