Feature/volume-count #856
Merged
Feature/volume-count #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was not addressed in the previous pull request, but I did notice that the volume-count commands include the optional argument, "--columns". I was not sure if this argument serves any practical purpose, since the output table for this command only has two columns. If desired, I'm happy to remove this optional argument, but I wanted to verify that it was not desired beforehand. |
|
Can I close #819 ? Since there are only 2 columns removing --columns would make sense to me. |
|
Alright, thanks! I have removed the '--columns' argument from the volume-count commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(follow-up for PR #819)
This pull request includes a new branch in which I cleaned up the commit history a bit and addressed the feedback on pull request #819.