-
Notifications
You must be signed in to change notification settings - Fork 194
STAAS (File and Block) Hourly billing changes #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e733e81
to
4b75043
Compare
4b75043
to
c9170cd
Compare
c9170cd
to
879dd19
Compare
are these changes good to be merged? |
QE testing is still in progress for this, but everything seems to be okay so far. |
Okay, we have found at least one bug. I'll try to get a fix pushed up tomorrow morning. |
Update: The bug mentioned above is not actually related to the changes in this pull request. I've created issue #870 to handle this bug. I have not yet received confirmation that QE testing is completed, but I will follow up with the QE team. |
@dpickle2 |
@allmightyspiff QE has tested the ordering functions and has not found any issues related to these changes. Unless there are any other concerns you have, I think this pull request should be ready to merge. |
Add the '--billing' flag to volume-order and volume-duplicate commands, and add logic within snapshot space and replication orders to use hourly billing if the original volume used hourly billing.