Skip to content

Conversation

sunilvrajput
Copy link

@sunilvrajput sunilvrajput commented Aug 28, 2017

Add the '--billing' flag to volume-order and volume-duplicate commands, and add logic within snapshot space and replication orders to use hourly billing if the original volume used hourly billing.

@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@dpickle2 dpickle2 self-requested a review August 29, 2017 21:53
@dpickle2 dpickle2 changed the title STORAGE-3308: STAAS ( File and Block) Hourly billing changes STAAS (File and Block) Hourly billing changes Aug 29, 2017
@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 85.206% when pulling 879dd19 on sunilvrajput:sunil-sl-master into 05b95c7 on softlayer:master.

@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@softlayer softlayer deleted a comment from coveralls Aug 29, 2017
@allmightyspiff
Copy link
Member

are these changes good to be merged?

@dpickle2
Copy link

QE testing is still in progress for this, but everything seems to be okay so far.

@dpickle2
Copy link

Okay, we have found at least one bug. I'll try to get a fix pushed up tomorrow morning.

@dpickle2
Copy link

dpickle2 commented Sep 5, 2017

Update: The bug mentioned above is not actually related to the changes in this pull request. I've created issue #870 to handle this bug. I have not yet received confirmation that QE testing is completed, but I will follow up with the QE team.

@allmightyspiff
Copy link
Member

@dpickle2
Just let me know when you are ready for this request to be merged. The code itself seems fine to me.

@dpickle2
Copy link

dpickle2 commented Sep 5, 2017

@allmightyspiff QE has tested the ordering functions and has not found any issues related to these changes. Unless there are any other concerns you have, I think this pull request should be ready to merge.

@allmightyspiff allmightyspiff merged commit 0800ae6 into softlayer:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants