Replace findNodeHandle with reading _componentViewTag #6720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #6719.
This is better because it doesn't enter the traversal codepath inside React. The
findNodeHandle
calculation inside theAnimated.View
itself is not so bad because it's short circuited inside for native refs (at least withView
). Whereas passing a class instance like here always triggers the slower path in React. Regardless, it's already computed so why compute again?Test plan
I've added console logs in our app to verify whether
animatedComponent._componentViewTag === findNodeHandle(animatedComponent)
and it always turned out true in the cases I hit.Not sure if there any cases where those could be different.