Skip to content

Conversation

michielbdejong
Copy link
Contributor

my implementation at https://github.com/inrupt/wac-ldp choked on this when I tried to use it as a test fixture :)

@michielbdejong
Copy link
Contributor Author

@kjetilk can you review, and if accepted, either merge or give me merge permissions?

Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, good to have examples executable.

@kjetilk
Copy link
Member

kjetilk commented May 29, 2019

The repo is set up with a requirement for two reviewers.

Copy link

@megoth megoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michielbdejong
Copy link
Contributor Author

Thanks! @megoth can you merge?

@kjetilk kjetilk merged commit 40d733d into solid:master May 29, 2019
@michielbdejong michielbdejong deleted the patch-2 branch May 30, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants