Improve wording on delegated events propagation #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
milomg
approved these changes
Jul 30, 2025
LadyBluenotes
requested changes
Jul 30, 2025
Co-authored-by: Sarah <gerrardsarah@gmail.com>
LadyBluenotes
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description(required)
Milo raised the issue that our wording of "delegated events propagate through the component tree" is slightly incorrect/confusing. This PR aims to clarify that.
Delegated events flow the dom tree, but components like Portal make these jump to a different element, so while a component changed the flow of the event, is not like events exclusively follow the component tree.
Discord thread in #docs channel https://discord.com/channels/722131463138705510/861229287868858379/1399549944179982438
Invitation if you need: https://discord.gg/solidjs
Related issues & labels