Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve typings for state setter by utilizing readonly #495

Merged
merged 1 commit into from
Jun 19, 2021
Merged

improve typings for state setter by utilizing readonly #495

merged 1 commit into from
Jun 19, 2021

Conversation

cynecx
Copy link
Contributor

@cynecx cynecx commented Jun 19, 2021

I am not that familiar with typescript's advance type system. The DeepReadonly utility was taken from: https://pastebin.com/Z8YSdThR.

@cynecx cynecx marked this pull request as draft June 19, 2021 00:18
@cynecx
Copy link
Contributor Author

cynecx commented Jun 19, 2021 •
edited
Loading

Seemsto have some issues (withreconcile`) fixed

@cynecx cynecx marked this pull request as ready for review June 19, 2021 01:00
@ryansolid
Copy link
Member

Thank you.

@ryansolid ryansolid merged commit 99b3182 into solidjs:main Jun 19, 2021
@cynecx cynecx deleted the readonly-state branch June 19, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cynecx @ryansolid