[azure][feat] Add machine learning resources collection (#2174)

Co-authored-by: Matthias Veit <matthias_veit@yahoo.de>
Co-authored-by: Matthias Veit <aquamatthias@users.noreply.github.com>

Author: 1101-1

plugins/azure/fix_plugin_azure/azure_client.py

@@ -43,7 +43,7 @@ def is_retryable_exception(e: Exception) -> bool:
         return True
     if isinstance(e, HttpResponseError):
         error_code = getattr(e.error, "code", None)
-        status_code = getattr(e.response, "status_code", None)
+        status_code = getattr(e, "status_code", None)
 
         if error_code == "TooManyRequests" or status_code == 429:
             log.debug(f"Azure API request limit exceeded or throttling, retrying with exponential backoff: {e}")

plugins/azure/fix_plugin_azure/collector.py

@@ -49,6 +49,11 @@
 )
 from fix_plugin_azure.resource.storage import AzureStorageAccountUsage, AzureStorageSku, resources as storage_resources
 from fix_plugin_azure.resource.web import resources as web_resources
+from fix_plugin_azure.resource.machinelearning import (
+    AzureMachineLearningUsage,
+    AzureMachineLearningVirtualMachineSize,
+    resources as ml_resources,
+)
 from fixlib.baseresources import Cloud, GraphRoot, BaseAccount, BaseRegion
 from fixlib.core.actions import CoreFeedback, ErrorAccumulator
 from fixlib.graph import Graph
@@ -80,6 +85,7 @@ def resource_with_params(clazz: Type[MicrosoftResource], param: str) -> bool:
     + sql_resources
     + storage_resources
     + web_resources
+    + ml_resources
 )
 all_resources = subscription_resources + graph_resources  # defines all resource kinds. used in model check
 
@@ -241,7 +247,7 @@ def rm_nodes(cls, ignore_kinds: Optional[Type[Any]] = None, check_pred: bool = T
 
         def remove_usage_zero_value() -> None:
             for node in self.graph.nodes:
-                if not isinstance(node, (AzureNetworkUsage, AzureStorageAccountUsage)):
+                if not isinstance(node, (AzureNetworkUsage, AzureStorageAccountUsage, AzureMachineLearningUsage)):
                     continue
                 # Azure Usage just keep info about how many kind of resources on account exists
                 # Check if the current usage value of the Azure Usage node is 0
@@ -254,6 +260,7 @@ def remove_usage_zero_value() -> None:
         rm_nodes(AzureExpressRoutePortsLocation, AzureSubscription)
         rm_nodes(AzureNetworkVirtualApplianceSku, AzureSubscription)
         rm_nodes(AzureDiskType, AzureSubscription)
+        rm_nodes(AzureMachineLearningVirtualMachineSize, AzureLocation)
         rm_nodes(AzureStorageSku, AzureLocation)
         rm_nodes(AzureMysqlServerType, AzureSubscription)
         rm_nodes(AzurePostgresqlServerType, AzureSubscription)

plugins/azure/fix_plugin_azure/resource/base.py

@@ -611,6 +611,8 @@ class AzureTrackedResource:
         "location": S("location"),
         "system_data": S("systemData") >> Bend(AzureSystemData.mapping),
         "type": S("type"),
+        "ctime": S("systemData", "createdAt"),
+        "mtime": S("systemData", "lastModifiedAt"),
     }
     location: Optional[str] = field(default=None, metadata={'description': 'The geo-location where the resource lives'})  # fmt: skip
     system_data: Optional[AzureSystemData] = field(default=None, metadata={'description': 'Metadata pertaining to creation and last modification of the resource.'})  # fmt: skip
@@ -623,6 +625,8 @@ class AzureProxyResource:
     mapping: ClassVar[Dict[str, Bender]] = {
         "system_data": S("systemData") >> Bend(AzureSystemData.mapping),
         "type": S("type"),
+        "ctime": S("systemData", "createdAt"),
+        "mtime": S("systemData", "lastModifiedAt"),
     }
     system_data: Optional[AzureSystemData] = field(default=None, metadata={'description': 'Metadata pertaining to creation and last modification of the resource.'})  # fmt: skip
     type: Optional[str] = field(default=None, metadata={'description': 'The type of the resource. E.g. Microsoft.Compute/virtualMachines or Microsoft.Storage/storageAccounts '})  # fmt: skip
@@ -828,9 +832,9 @@ def add_node(self, node: MicrosoftResourceType, source: Optional[Json] = None) -
         # add edge from location to resource
         if self.location:
             last_edge_key = self.add_edge(self.location, node=node)
-        elif source and "location" in source:
+        elif (source) and (source_location := source.get("location")):
             # reference the location node if available
-            if location := self.location_lookup.get(source["location"]):
+            if location := self.location_lookup.get(source_location):
                 node._region = location
                 last_edge_key = self.add_edge(location, node=node)
         if source and "locations" in source: