Skip to content

Commit 73efbf3

Browse files
authored
[gcp][feat] Add Pub/Sub service collection (#2287)
1 parent 43a1200 commit 73efbf3

File tree

6 files changed

+431
-14
lines changed

6 files changed

+431
-14
lines changed

fixlib/fixlib/baseresources.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1112,7 +1112,7 @@ class BaseQueue(BaseResource):
11121112
_categories: ClassVar[List[Category]] = [Category.storage]
11131113
queue_type: Optional[QueueType] = None
11141114
approximate_message_count: Optional[int] = None
1115-
message_retention_period: Optional[int] = None
1115+
message_retention_period_days: Optional[int] = None
11161116

11171117

11181118
@define(eq=False, slots=False)

plugins/aws/fix_plugin_aws/resource/sqs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class AwsSqsQueue(AwsResource, BaseQueue, HasResourcePolicy):
8181
"sqs_delay_seconds": S("DelaySeconds") >> AsInt(),
8282
"sqs_receive_message_wait_time_seconds": S("ReceiveMessageWaitTimeSeconds") >> AsInt(),
8383
"sqs_managed_sse_enabled": S("SqsManagedSseEnabled") >> AsBool(),
84-
"message_retention_period": S("MessageRetentionPeriod") >> AsInt(),
84+
"message_retention_period_days": S("MessageRetentionPeriod") >> AsInt(),
8585
"approximate_message_count": S("ApproximateNumberOfMessages") >> AsInt(),
8686
}
8787
sqs_queue_url: Optional[str] = field(default=None)

plugins/azure/fix_plugin_azure/resource/storage.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
MetricUnit,
2727
ModelReference,
2828
PhantomBaseResource,
29+
QueueType,
2930
)
3031
from fixlib.json_bender import K, Bender, S, ForallBend, Bend, AsBool
3132
from fixlib.types import Json
@@ -320,8 +321,8 @@ class AzureStorageQueue(MicrosoftResource, BaseQueue):
320321
"tags": S("tags", default={}),
321322
"name": S("name"),
322323
"queue_metadata": S("properties", "metadata"),
323-
"queue_type": K("standard"),
324-
"message_retention_period": K(7),
324+
"queue_type": K(QueueType.STANDARD),
325+
"message_retention_period_days": K(7),
325326
"approximate_message_count": S("properties", "approximateMessageCount"),
326327
}
327328
queue_metadata: Optional[Dict[str, str]] = field(default=None, metadata={'description': 'A name-value pair that represents queue metadata.'}) # fmt: skip

plugins/gcp/fix_plugin_gcp/collector.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
filestore,
1717
cloudfunctions,
1818
monitoring,
19+
pubsub,
1920
)
2021
from fix_plugin_gcp.resources.base import GcpResource, GcpProject, ExecutorQueue, GraphBuilder, GcpRegion, GcpZone
2122
from fix_plugin_gcp.utils import Credentials
@@ -36,6 +37,7 @@
3637
+ firestore.resources
3738
+ filestore.resources
3839
+ cloudfunctions.resources
40+
+ pubsub.resources
3941
)
4042

4143

0 commit comments

Comments
 (0)