[core][feat] Allow update node with force (#2047)

Author: aquamatthias

fixcore/fixcore/db/graphdb.py

@@ -100,7 +100,13 @@ async def update_deferred_edges(self, edges: List[Tuple[NodeId, NodeId, str]], t
 
     @abstractmethod
     async def update_node(
-        self, model: Model, node_id: NodeId, patch_or_replace: Json, replace: bool, section: Optional[str]
+        self,
+        model: Model,
+        node_id: NodeId,
+        patch_or_replace: Json,
+        replace: bool,
+        section: Optional[str],
+        force: bool = False,
     ) -> Json:
         pass
 
@@ -335,9 +341,15 @@ def deletion_query(edge_collection: str) -> str:
         return updated_edges, deleted_edges
 
     async def update_node(
-        self, model: Model, node_id: NodeId, patch_or_replace: Json, replace: bool, section: Optional[str]
+        self,
+        model: Model,
+        node_id: NodeId,
+        patch_or_replace: Json,
+        replace: bool,
+        section: Optional[str],
+        force: bool = False,
     ) -> Json:
-        return await self.update_node_with(self.db, model, node_id, patch_or_replace, replace, section)
+        return await self.update_node_with(self.db, model, node_id, patch_or_replace, replace, section, force)
 
     async def update_node_with(
         self,
@@ -347,6 +359,7 @@ async def update_node_with(
         patch_or_replace: Json,
         replace: bool,
         section: Optional[str],
+        force: bool = False,
     ) -> Json:
         log.info(f"Update node with node_id={node_id}, section={section}, replace={replace}, update={patch_or_replace}")
         node = await self.by_id_with(db, node_id)
@@ -400,7 +413,7 @@ async def update_resolved_property(id_prop: ResolveProp, patch: Json, history: b
             for prop in ra.resolved_props():
                 if value_in_path(node, prop.extract_path) != (nv := value_in_path(update, prop.extract_path)):
                     set_value_in_path(nv, prop.to_path, changes)
-            if changes:
+            if changes or force:
                 await update_resolved_property(rid, changes, False)
                 await update_resolved_property(rid, changes, True)
 
@@ -1649,7 +1662,13 @@ async def update_deferred_edges(self, edges: List[Tuple[NodeId, NodeId, str]], t
         return updated, deleted
 
     async def update_node(
-        self, model: Model, node_id: NodeId, patch_or_replace: Json, replace: bool, section: Optional[str]
+        self,
+        model: Model,
+        node_id: NodeId,
+        patch_or_replace: Json,
+        replace: bool,
+        section: Optional[str],
+        force: bool = False,
     ) -> Json:
         result = await self.real.update_node(model, node_id, patch_or_replace, replace, section)
         await self.event_sender.core_event(CoreEvent.NodeUpdated, {"graph": self.graph_name, "section": section})

fixcore/fixcore/web/api.py

@@ -1014,6 +1014,7 @@ async def update_node(self, request: Request, deps: TenantDependencies) -> Strea
         section = section_of(request)
         graph = deps.db_access.get_graph_db(graph_id)
         patch = await self.json_from_request(request)
+        force = request.query.get("force", "false").lower() == "true"
         md = await deps.model_handler.load_model(graph_id)
         node: Optional[Json] = None
         if section == Section.metadata:
@@ -1023,7 +1024,7 @@ async def update_node(self, request: Request, deps: TenantDependencies) -> Strea
             async for n in graph.update_nodes_desired(md, patch, [node_id]):
                 node = n
         else:
-            node = await graph.update_node(md, node_id, patch, False, section)
+            node = await graph.update_node(md, node_id, patch, False, section, force)
         if node is None:
             return web.HTTPNotFound(text=f"No such node with id {node_id} in graph {graph_id}")
         return await single_result(request, node)