Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Add Revealer entry #331

Merged
merged 18 commits into from
Jun 20, 2023
Merged

library: Add Revealer entry #331

merged 18 commits into from
Jun 20, 2023

Conversation

AkshayWarrier
Copy link
Contributor

Adds Revealer demo entry

Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.

wdyt of adding an example? A cross-fade between 2 overlays can look very cool. Feel free to play around and find something nice.


Revealer revealer {
transition-duration: 300;
transition-type: slide_up;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
transition-type: slide_up;
// https://docs.gtk.org/gtk4/enum.RevealerTransitionType.html
transition-type: slide_up;

src/Library/demos/Revealer/main.blp Outdated Show resolved Hide resolved
src/Library/demos/Revealer/main.js Outdated Show resolved Hide resolved
src/Library/demos/Revealer/main.js Outdated Show resolved Hide resolved
src/Library/demos/Revealer/main.js Outdated Show resolved Hide resolved
SoNiC-HeRE and others added 14 commits June 20, 2023 19:59
* Adds Adw.AboutWindow Demo
* Updated Link
* Updated Code
* Updated Icon
* Added Acknowledgement Section
* library: Add AdwAnimation entry
* Animation: Fix CallbackAnimationTarget and add AnimationTarget example
* Animation: Add links
* Animation: Changes from review
* Animation: Update main.css
* Added TextView Demo
* Updated JS Code
* Updated Code
* Formatting Changes
* libary: Add SpinButton entry
* Spin Button: Add link to tutorial
* Spin Button: Changes from review
* Spin Button: Translated strings
* Spin Button: Add comments for clarity
* library: Add AdwBanner entry
* Banner: Translate strings
* library: add carousel entry
* make carousel functional
* add main.vala
* fix horizontal orientation
* fix alignment on prefsrow
* main.vala: fix formatting
* Apply suggestions from code review

   Fix formatting and remove stuff
   Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
* main.blp: fix spacing
* remove quotes

---------

Co-authored-by: wlhunter <wlhunter@go.olemiss.edu>
Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
Signal handlers have semantic around return values.
Let's not encourage developers to use async signal handlers as it can lead to hard to debug issues.

Also some other improvements
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@sonnyp sonnyp merged commit 8e9aa91 into main Jun 20, 2023
@sonnyp sonnyp deleted the akshaywarrier/revealer branch June 20, 2023 18:06
sonnyp pushed a commit that referenced this pull request Jul 5, 2023
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants