library: add Carousel entry #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
requested changes
Jun 14, 2023
Contributor
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
Nice one! Just a few tweaks and it LGTM.
Fix formatting and remove stuff Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
Contributor
Author
|
a few tweaks have been tweaked |
sonnyp
pushed a commit
that referenced
this pull request
Jun 20, 2023
* library: add carousel entry * make carousel functional * add main.vala * fix horizontal orientation * fix alignment on prefsrow * main.vala: fix formatting * Apply suggestions from code review Fix formatting and remove stuff Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com> * main.blp: fix spacing * remove quotes --------- Co-authored-by: wlhunter <wlhunter@go.olemiss.edu> Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
* library: add carousel entry * make carousel functional * add main.vala * fix horizontal orientation * fix alignment on prefsrow * main.vala: fix formatting * Apply suggestions from code review Fix formatting and remove stuff Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com> * main.blp: fix spacing * remove quotes --------- Co-authored-by: wlhunter <wlhunter@go.olemiss.edu> Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we aren't deprecated yet!