Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vim keybindings #703

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mohamedelhefni
Copy link

this PR is addressing the feature requested at #701

Changes

  • Add Ace vim bindings js file
  • Add the ability for user to switch between editor modes (Normal, Vim)
    • Store user last choice in localstorage

@mohamedelhefni
Copy link
Author

Ping @sosedoff

static/css/app.css Outdated Show resolved Hide resolved
static/js/keybinding-vim.js Show resolved Hide resolved
static/js/app.js Outdated Show resolved Hide resolved
@sosedoff
Copy link
Owner

Could you rebase/or update with master branch?

@mohamedelhefni
Copy link
Author

I updated the branch with latest changes from master branch

@sosedoff
Copy link
Owner

sosedoff commented May 1, 2024

IMO the cog button has no business being in the vicinity of "Execute"/"Explain" buttons area since its purely a configuration option and not something a user would change often (myself included). I propose you move the cog button to the top-right area of the query input box as its mosly blank space and we can make UX a bit more slim.

Screenshot 2024-04-30 at 11 06 53 PM

LMK if you have any questions or need to clarify anything.

@mohamedelhefni
Copy link
Author

image
I moved the cog button to the top-right area as you proposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants