Skip to content

Commit bfe6225

Browse files
authored
Merge branch 'master' into gradingAsync
2 parents a5b8e71 + 105546f commit bfe6225

File tree

7 files changed

+105
-244
lines changed

7 files changed

+105
-244
lines changed

package.json

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@szhsin/react-menu": "^4.0.0",
4141
"@tanstack/react-table": "^8.9.3",
4242
"@tremor/react": "^1.8.2",
43-
"ace-builds": "^1.4.14",
43+
"ace-builds": "^1.36.3",
4444
"acorn": "^8.9.0",
4545
"ag-grid-community": "^32.0.2",
4646
"ag-grid-react": "^32.0.2",
@@ -53,7 +53,7 @@
5353
"flexboxgrid-helpers": "^1.1.3",
5454
"hastscript": "^9.0.0",
5555
"i18next": "^23.11.2",
56-
"i18next-browser-languagedetector": "^7.2.1",
56+
"i18next-browser-languagedetector": "^8.0.0",
5757
"java-slang": "^1.0.13",
5858
"js-cookie": "^3.0.5",
5959
"js-slang": "^1.0.76",
@@ -68,14 +68,14 @@
6868
"query-string": "^9.0.0",
6969
"re-resizable": "^6.9.9",
7070
"react": "^18.3.1",
71-
"react-ace": "^10.1.0",
71+
"react-ace": "^12.0.0",
7272
"react-copy-to-clipboard": "^5.1.0",
7373
"react-debounce-render": "^8.0.2",
7474
"react-dom": "^18.3.1",
7575
"react-drag-drop-files": "^2.3.10",
7676
"react-draggable": "^4.4.5",
7777
"react-dropzone": "^14.2.3",
78-
"react-i18next": "^14.1.0",
78+
"react-i18next": "^15.0.0",
7979
"react-konva": "^18.2.10",
8080
"react-latex-next": "^3.0.0",
8181
"react-mde": "^11.5.0",
@@ -94,7 +94,7 @@
9494
"showdown": "^2.1.0",
9595
"sourceror": "^0.8.5",
9696
"unified": "^11.0.0",
97-
"uuid": "^9.0.0",
97+
"uuid": "^11.0.2",
9898
"xlsx": "https://cdn.sheetjs.com/xlsx-0.20.2/xlsx-0.20.2.tgz",
9999
"xml2js": "^0.6.0",
100100
"yareco": "^0.1.5"
@@ -129,7 +129,6 @@
129129
"@types/react-test-renderer": "^18.0.0",
130130
"@types/redux-mock-store": "^1.0.3",
131131
"@types/showdown": "^2.0.1",
132-
"@types/uuid": "^9.0.0",
133132
"@types/xml2js": "^0.4.11",
134133
"babel-jest": "^29.7.0",
135134
"buffer": "^6.0.3",
@@ -145,7 +144,7 @@
145144
"eslint-plugin-simple-import-sort": "^12.1.1",
146145
"https-browserify": "^1.0.0",
147146
"husky": "^9.0.0",
148-
"npm-run-all2": "^6.0.0",
147+
"npm-run-all2": "^7.0.0",
149148
"os-browserify": "^0.3.0",
150149
"path-browserify": "^1.0.1",
151150
"prettier": "^3.3.3",

renovate.json

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
{
22
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
3-
"extends": ["config:base", ":dependencyDashboard", "group:allNonMajor", ":label(dependencies)"],
3+
"extends": [
4+
"config:recommended",
5+
":dependencyDashboard",
6+
"group:allNonMajor",
7+
":label(dependencies)"
8+
],
49
"major": {
510
"dependencyDashboardApproval": true
611
},
712
"packageRules": [
813
{
9-
"matchPackagePatterns": ["*"],
10-
"rangeStrategy": "update-lockfile"
14+
"rangeStrategy": "update-lockfile",
15+
"matchPackageNames": ["*"]
1116
}
1217
],
1318
"enabledManagers": ["npm"]

src/commons/assessmentWorkspace/AssessmentWorkspace.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,9 +191,10 @@ const AssessmentWorkspace: React.FC<AssessmentWorkspaceProps> = props => {
191191
}, []);
192192

193193
useEffect(() => {
194-
handleTeamOverviewFetch(props.assessmentId);
195-
// eslint-disable-next-line react-hooks/exhaustive-deps
196-
}, []);
194+
if (assessmentOverview && assessmentOverview.maxTeamSize > 1) {
195+
handleTeamOverviewFetch(props.assessmentId);
196+
}
197+
}, [assessmentOverview, handleTeamOverviewFetch, props.assessmentId]);
197198

198199
/**
199200
* After mounting (either an older copy of the assessment

src/commons/utils/AceHelper.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,15 @@ export const selectMode = (chapter: Chapter, variant: Variant, library: string)
3131
ModeSelector(chapter, variant, library);
3232
};
3333

34+
import 'ace-builds/src-noconflict/mode-c_cpp';
35+
import 'ace-builds/src-noconflict/mode-html';
36+
import 'ace-builds/src-noconflict/mode-java';
37+
import 'ace-builds/src-noconflict/mode-javascript';
38+
import 'ace-builds/src-noconflict/mode-python';
39+
import 'ace-builds/src-noconflict/mode-scheme';
40+
import 'ace-builds/src-noconflict/mode-typescript';
41+
import 'js-slang/dist/editors/ace/theme/source';
42+
3443
export const getModeString = (chapter: Chapter, variant: Variant, library: string) => {
3544
// TODO: Create our own highlighting rules for the different sublanguages
3645
switch (chapter) {

src/pages/academy/gameSimulator/subcomponents/chapterSimulator/ChapterSimulatorTextLoader.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import 'ace-builds/webpack-resolver';
2-
31
import { Button, Classes, Tab, Tabs } from '@blueprintjs/core';
42
import { useState } from 'react';
53
import { toTxtPath } from 'src/features/game/assets/TextAssets';

src/pages/achievement/control/AchievementControl.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,13 @@ const AchievementControl: React.FC = () => {
3535
[dispatch]
3636
);
3737

38-
// TODO: This is a hacky fix. By right, we shouldn't need to use an
39-
// inferencer instance since we can encapsulate the logic using hooks
40-
// and component state.
4138
const [initialAchievements, initialGoals] = useTypedSelector(state => [
4239
state.achievement.achievements,
4340
state.achievement.goals
4441
]);
4542
const inferencer = useMemo(
4643
() => new AchievementInferencer(initialAchievements, initialGoals),
47-
// We only want to create the inferencer once
48-
// eslint-disable-next-line react-hooks/exhaustive-deps
49-
[]
44+
[initialAchievements, initialGoals]
5045
);
5146

5247
/**

0 commit comments

Comments
 (0)