Skip to content

Conversation

Adimote
Copy link
Member

@Adimote Adimote commented Mar 9, 2018

Add a (Latest) to the latest update to improve readability

{{ range $index, $_ := .Pages.ByDate.Reverse }}
<tr>
<td><a href='{{ .RelPermalink }}' title="See a summary of the changes in this release">{{ .Title }}</a></td>
<td><a href='{{ .RelPermalink }}' title="See a summary of the changes in this release">{{ .Title }}</a>{{ if (eq $index 0) }}(Latest){{ end }}</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space missing between the update name and (Latest).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it could be nice to have the text (Latest) in a different colour to highlight it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in d3101fb, I think colouring it might be a bit tacky.

{{ range $index, $_ := .Pages.ByDate.Reverse }}
<tr>
<td><a href='{{ .RelPermalink }}' title="See a summary of the changes in this release">{{ .Title }}</a></td>
<td><a href='{{ .RelPermalink }}' title="See a summary of the changes in this release">{{ .Title }}</a>{{ if (eq $index 0) }}(Latest){{ end }}</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it could be nice to have the text (Latest) in a different colour to highlight it.

@Adimote Adimote changed the title Point at the latest update Tag the latest update Mar 9, 2018
@Adimote Adimote dismissed trickeydan’s stale review March 10, 2018 10:33

please re-review, as I've fixed the issues

@Adimote Adimote requested a review from trickeydan March 10, 2018 10:33
@RealOrangeOne
Copy link
Member

Why is this necessary? The latest release will always be the top-most. This just makes the page unnecessarily noisy?

@kierdavis
Copy link
Member

Since the release dates are clearly visible, I don't feel this is necessary.

Copy link
Member

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the list is ordered by date, and version numbers are clearly visible, I don't think this is necessary

trickeydan
trickeydan previously approved these changes Mar 20, 2018
@Adimote
Copy link
Member Author

Adimote commented Mar 23, 2018

We need to think about the UX here, having some bold text pointing where people should look is very helpful.

Especially because there's no obvious order for the update name on the far left column, some may think that 'Kickstart 2018' is the latest.

@PeterJCLaw
Copy link
Contributor

We need to think about the UX here,

This is a perfectly reasonable point. However it's non-obvious to me that this implementation is the best. Personally I think it adds visual clutter which decreases the UX.

We should also consider the technical overhead of doing this. No change that adds things is free of maintenance or cognitive load when reading the source. All features are forms of complexity. We should be judging whether that complexity is worth the benefits of the feature.

having some bold text pointing where people should look is very helpful.

I agree with that, though I'd generalise it that visual markers of some form can help point things out.
How about making the link (or maybe even the whole row) bold rather than adding more text?
If we're doing the whole row, how about a slightly different background colour?

Especially because there's no obvious order for the update name on the far left column, some may think that 'Kickstart 2018' is the latest.

I disagree. Everyone in the target audience knows what Kickstart was and when it was. That the rest are named after dates means that it's pretty obvious what the ordering is.
Even if that weren't the case, then the "Release date" column is pretty clear about the ordering. I think it's reasonable to expect people to read the whole table while scanning from left to right looking for the download link.

@PeterJCLaw
Copy link
Contributor

I think the ideal implementation would add a class to the row of the current update and then that would be styled. This nicely separates content from styling, yet still allows for any of the visual implementations which have been proposed so far.

Adimote added 2 commits March 24, 2018 15:52
- Use a class identifier for the row of the table
@Adimote
Copy link
Member Author

Adimote commented Mar 24, 2018

Tests are failing due to an unrelated link check

@Adimote Adimote dismissed RealOrangeOne’s stale review March 24, 2018 15:57

Please don't request changes unless you're certain that changes need to be made

@RealOrangeOne
Copy link
Member

there's no obvious order for the update name on the far left column

I'm not sure if this was done before this PR was made, but the release date is in the list, so it's obvious which way round it is. The names are also somewhat-related to when they were released (I don't like this, it's on my list!). But I think adding additional noise isnt the answer.

An idea I was toying with on something external, was having a specific entry outside the table, for the latest, and further down, having a table of all releases. Much like the buttons we have at the bottom of the update page, we specifically move the latest release buttons out of the table flow, making it incredibly obvious, without adding noise to the table. Most versioned software downloads employ a similar approach.

@trickeydan
Copy link
Contributor

@Adimote Same broken link issue occurred in #125, have excluded microsoft links.

@RealOrangeOne RealOrangeOne mentioned this pull request Jul 19, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants